querydb: cleanup/simplify dependency tree, move classes into querydb namespace#2758
Closed
mpollmeier wants to merge 2 commits intomasterfrom
Closed
querydb: cleanup/simplify dependency tree, move classes into querydb namespace#2758mpollmeier wants to merge 2 commits intomasterfrom
mpollmeier wants to merge 2 commits intomasterfrom
Conversation
Contributor
mpollmeier
commented
May 24, 2023
mpollmeier
commented
- console shouldn't depend on macros
- move querydb classes into querydb namespace: q, Query, QueryDatabase
* console shouldn't depend on macros * Query shouldn't live in `macros`, as it's namespace already suggested
Contributor
Author
|
only bring in after we throw out scala2: #2595 |
DavidBakerEffendi
added
the
infrastructure
Contributor
|
@mpollmeier I guess we can close this PR as its seems to be long outdated right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.